openrightsgroup / cmp-issues

Centralised issue-tracking for the Blocked backend
2 stars 0 forks source link

Add categories for "Who?" and "Damage" to classify user reports #197

Closed alexhaydock closed 5 years ago

alexhaydock commented 5 years ago

After discussion with @jimkillock, it has been identified that it would be useful to be able to classify reports in the same way that URLs are currently classified using the categories feature on the "Review Categories" tab.

To classify reports, it would be useful to have two open-ended category labels that could be attached: "Who?", and "Damage".

"Who?" would be useful to classify reports based on whether they come from a site/business owner or a site user etc., and "Damage" would be useful to classify whether the report has cited any damage caused by the block (lost sales, customers complaining etc.)

Ideally, these tags would work the same way as the categories in the "Review Categories" section - in that they can be arbitrarily added by admins when required, or selected from a list for categories that already exist.

Thanks

edjw commented 5 years ago

What would be the possible choices to the questions of "Who made the report?" and "What, if any, damage was reported?"

alexhaydock commented 5 years ago

Likely:

"Who made the report?"

"What, if any, damage was reported?"

But the idea of having an open-ended category like the "review category" currently functions is that admins could add these labels as they are required, even though I expect the list to stay fairly small.

JimKillock commented 5 years ago

The ‘damage reported’ probably needs to allow multiple options to be checked, as several may be cited

alexhaydock commented 5 years ago

For the purposes of the research this ticket will help with, #198 is also particularly important and (hopefully) is an easy addition.

edjw commented 5 years ago

Can we also expose the data from the report stage where the reporter clicks a checkbox saying one of: I am a user/I am the owner/ someone who cares about censorship? This would be useful information for Alex while he's doing this research

dantheta commented 5 years ago

I've deployed a first pass at this - there may be some rough edges or bugs but they should be fairly easy to take care of tomorrow.

I can't find the site owner/user datain the system at the moment - I'll keep looking.

alexhaydock commented 5 years ago

This is working well seemingly, thanks Dan.

The only issue I'm running into is the fact that it stores the data per-report rather than per-URL. As the actual report text and content is the same across all of the ISPs that a single URL is reported to then it makes more sense to me to store this data just once for each URL.

Edit: For now I am categorising the user-submitted text for the URLs in the database with this new tool, but I am ensuring that I do that categorisation process on only one ISP report entry per URL, no matter how many ISP reports belong to each URL.

Hopefully this means it wouldn't be too difficult for you to take the data I've entered and move it to apply it to the URLs rather than just the individual reports? That's my hope anyway.

dantheta commented 5 years ago

On 2019-02-21 10:54, Alex Haydock wrote:

This is working well seemingly, thanks Dan.

The only issue I'm running into is the fact that it stores the data per-report rather than per-URL. As the actual report text and content is the same across all of the ISPs that a single URL is reported to then it makes more sense to me to store this data just once for each URL.

Yep, that makes sense. I can change that and move the data that's been added so far. If you want to just only use these fields for one report of a given URL, that would be fine for now, and the shared view should be available tomorrow. I should also have time to tidy up the UI a
tiny bit.

When we start allowing reports to be cancelled and re-filed by a different user, we may find that an assigned reporter category is out of date. The comments log should serve as a historical explanation for those changes though.

alexhaydock commented 5 years ago

I love the "User domain matches target domain" feature! Very useful time saver.

Are you able to tweak it with some kind of wildcard that ignores a leading www. in the domain?

Edit: Maybe I mistook this as an automated feature where in fact it's entries you've added manually for testing.

alexhaydock commented 5 years ago

On 2019-02-21 10:54, Alex Haydock wrote: This is working well seemingly, thanks Dan. The only issue I'm running into is the fact that it stores the data per-report rather than per-URL. As the actual report text and content is the same across all of the ISPs that a single URL is reported to then it makes more sense to me to store this data just once for each URL. Yep, that makes sense. I can change that and move the data that's been added so far. If you want to just only use these fields for one report of a given URL, that would be fine for now, and the shared view should be available tomorrow. I should also have time to tidy up the UI a tiny bit. When we start allowing reports to be cancelled and re-filed by a different user, we may find that an assigned reporter category is out of date. The comments log should serve as a historical explanation for those changes though.

Ah yes thanks :) I edited my reply above after sending but notice you're on email rather than GitHub so probably didn't see it. I added:

Edit: For now I am categorising the user-submitted text for the URLs in the database with this new tool, but I am ensuring that I do that categorisation process on only one ISP report entry per URL, no matter how many ISP reports belong to each URL.

Hopefully this means it wouldn't be too difficult for you to take the data I've entered and move it to apply it to the URLs rather than just the individual reports? That's my hope anyway.

dantheta commented 5 years ago

I wish the system could claim credit for that one - that was actually me testing the record addition by hand :(

It's a good feature idea though. I should be able to update those programmatically.

alexhaydock commented 5 years ago

I wish the system could claim credit for that one - that was actually me testing the record addition by hand :( It's a good feature idea though. I should be able to update those programmatically.

Yeah, I started to figure it might be after I poked through a few more with email domains that matched their URLs and saw it didn't appear on them. Oh well, maybe a useful feature for the future if it's easy enough to add. :)

alexhaydock commented 5 years ago

Hi @dantheta

Just in case you're planning on working on this tonight - are you able to add some form of function allowing me to sort by the "damage" and "reporter" categories?

It doesn't really have to be anything that integrates nicely into the UI yet and could just be on a seperate page somewhere for now if it doesn't make sense anywhere else. But just some function allowing me to see all of the entries which have been placed into each category would be super useful for me to keep working on this research tomorrow.

Thanks :)

dantheta commented 5 years ago

The URL reporter category records have been moved across to url-level, and should be shared between reports for the same URL. I haven't been able to do the listing page tonight, but I might have time tomorrow morning.

alexhaydock commented 5 years ago

Seems to be working well. Thanks. :+1:

A listing page would be useful if you do get the chance but there are other things I can work on for the time being so no major rush.

alexhaydock commented 5 years ago

Everything in this ticket has been resolved as far as I can see. Closing.