search

openrightsgroup / cmp-issues

Centralised issue-tracking for the Blocked backend
2 stars 0 forks source link

Bug: ISP Report Admin #220

Closed JimKillock closed 5 years ago

JimKillock commented 5 years ago

Just to say that the ISP Report Admin page is listing one report per page

dantheta commented 5 years ago

Fixed! Was a little over-zealous fixing warnings and limited it to pagesize 1.

alexhaydock commented 5 years ago

Just to follow up on this - it seems like this problem still persists if any filter is used. The page doesn't extend beyond "1".

Fortunately it's not really an urgent problem for my current task of going through and assigning categories to anything "unassigned", though as my intent is to slowly remove everything from that category rather than browse through it.

Edit: I think I might be wrong that this applies to everything. This issue does still seem to be present, but only when using the "Unassigned" category that was just added to address #217

edjw commented 5 years ago

@dantheta – This bug is still persisting in some cases

dantheta commented 5 years ago

I'm seeing a full list of 25 items in unassigned, but the paging links only have one page (which I think is what Alex saw). Should have it fixed shortly.

dantheta commented 5 years ago

That should be fixed now. Its showing 98 pages with no filter applied, and 81 pages with the (unassigned) filter applied.

alexhaydock commented 5 years ago

That should be fixed now. Its showing 98 pages with no filter applied, and 81 pages with the (unassigned) filter applied.

Thanks! Yep, looks like this has fixed the issue I was seeing.

edjw commented 5 years ago

Can we close this?