search

openrightsgroup / cmp-issues

Centralised issue-tracking for the Blocked backend
2 stars 0 forks source link

Lists: add ISP filter #241

Closed JimKillock closed 5 years ago

JimKillock commented 5 years ago

Can we add a filter for the lists creation, that allows us to create a list of blocks relating to:

(1) Any mobile operator; or

(2) Any non-mobile operator; or

(3) Any specific network

This will help us build lists of errors that are relevant to specific ISP / mobile policies.

JimKillock commented 5 years ago

Add: can we also add a filter for .uk results only.

dantheta commented 5 years ago

Currently rebuilding the search index to include TLD and blocking network fields. This will allow the search engine to filter on these during list build and regular keyword querying.

JimKillock commented 5 years ago

Thanks Dan.

Could we also apply these criteria to an existing list - for instance by applying the search to a particular already existing list?

dantheta commented 5 years ago

Yep, that's planned. Filtering search and filtering existing lists use two separate facilities in the code, but they're both in progress.

dantheta commented 5 years ago

Search results can now be filtered by individual network. The network selection is carried through to saved list creation too.

The mobile and fixed line options don't work yet.

This may require a bit of testing!

dantheta commented 5 years ago

Filtering saved lists by ISP is now live.

all-mobile and all-fixed options to follow.

dantheta commented 5 years ago

Add: can we also add a filter for .uk results only.

This one's a bit trickier. I'd suggest splitting that off to a separate issue.

dantheta commented 5 years ago

fixed and mobile options are working. BT-Strict is inflating the fixed counts quite a bit.

JimKillock commented 5 years ago

Hi Dan, reviewing this ticket, and #239 – we were hoping, to complete the report this morning, to be able to:

(1) Filter the lists by ISP group, eg all MNOs (Vodafone, O2, Three, EE)

(2) Filter by Fixed line without BT-Strict (BT Light, Sky, TT, Virgin)

(3) Filter by MNOs + Fixed line without BT-Strict

(4) Filter the results above for .uk domains only

Is that possible at this stage? We may have a problem if not.

dantheta commented 5 years ago

I can switch the network filter to a set of checkboxes instead of include/exclude links. Is this needed for the lists summary page, the list detail pages or both?

Ed has already created .uk versions of some of the lists, which can then be filtered by ISP.

JimKillock commented 5 years ago

Checkboxes would work for sure.

.uk would still be very handy if even if it can’t be done today / right now.

edjw commented 5 years ago

The .uk lists I made were manually imported lists from Simon’s curated list of .uk sites.

They’re the top ones here: https://www.blocked.org.uk/lists https://www.blocked.org.uk/lists

––––– Ed Johnson-Williams

On 22 Mar 2019, at 08:52, JimKillock notifications@github.com wrote:

Checkboxes would work for sure.

.uk would still be very handy if even if it can’t be done today / right now. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openrightsgroup/cmp-issues/issues/241#issuecomment-475539835, or mute the thread https://github.com/notifications/unsubscribe-auth/AGPqCzDAiBgomSY3H63uzmBRwJPtmSAnks5vZJnRgaJpZM4btku-.

JimKillock commented 5 years ago

Understood. I would still like to have the .uk filter though.

dantheta commented 5 years ago

Hmm, #242 already covers the TLD filter options. I don't think there's anything else to add for this issue.