search

openrisc / or1k-glibc

glibc port for or1k
GNU General Public License v2.0
3 stars 7 forks source link

Rebase and prepare for upstream #8

Closed stffrdhrn closed 4 years ago

stffrdhrn commented 4 years ago

This follows issue #6 now that we have sorted out the test failures we can rebase and run all tests again. We should try to rebase often until all tests are done and we are ready for upstreaming.

This issue is to keep notes and track progress.

For upstreaming we need to:

Get all the glibc tests to pass again:

FAIL elf/check-abi-ld
FAIL elf/check-abi-libc
FAIL elf/check-localplt
FAIL malloc/tst-malloc-usable-tunables
FAIL malloc/tst-mxfast
FAIL misc/tst-sigcontext-get_pc
FAIL nptl/check-abi-libpthread
FAIL nptl/tst-audit-threads
FAIL nptl/tst-mutex10
FAIL rt/check-abi-librt
FAIL stdio-common/tst-vfprintf-width-prec-mem
FAIL support/tst-support_blob_repeat
FAIL sysvipc/test-sysvmsg
FAIL sysvipc/test-sysvsem
FAIL sysvipc/test-sysvshm

# MATH
FAIL malloc/tst-safe-linking
FAIL math/check-abi-libm
FAIL math/test-double-j1
FAIL math/test-float32-asinh
FAIL math/test-float32-cos
FAIL math/test-float32-cosh
FAIL math/test-float32-exp
FAIL math/test-float32-exp10
FAIL math/test-float32-j0
FAIL math/test-float32-j1
FAIL math/test-float32-lgamma
FAIL math/test-float32-sin
FAIL math/test-float32-tgamma
FAIL math/test-float32x-j1
FAIL math/test-float32-y0
FAIL math/test-float64-j1
FAIL math/test-float-asinh
FAIL math/test-float-cos
FAIL math/test-float-cosh
FAIL math/test-float-exp
FAIL math/test-float-exp10
FAIL math/test-float-j0
FAIL math/test-float-j1
FAIL math/test-float-lgamma
FAIL math/test-float-sin
FAIL math/test-float-tgamma
FAIL math/test-float-y0
FAIL math/test-ldouble-j1
stffrdhrn commented 4 years ago

The math failures were mostly from outdated ulps. I ran make regen-ulps and now there is 1 failure:

# failures
FAIL math/check-abi-libm

# test finish:   2020-04-29T01:23:18+00:00
# test time(m):  0
# test for file: math/subdir-tests.sum
# test wrapper:  /home/shorne/work/openrisc/or1k-utils/glibc/qemu-or1k-libc-chroot

# summary
     86 FAIL   (Explained by underflow issue)
    848 PASS
      3 UNSUPPORTED

The failure API check shows an easy to patch issue, now no unexplained math issues:

at math/check-abi-libm.out 
--- ../sysdeps/unix/sysv/linux/or1k/libm.abilist        2020-04-26 17:18:51.647752923 +0900
+++ /home/shorne/work/gnu-toolchain/build-glibc/math/libm.symlist       2020-04-29 06:45:46.173185212 +0900
@@ -770,0 +771,12 @@ GLIBC_2.29 pow F
+GLIBC_2.31 totalorder F
+GLIBC_2.31 totalorderf F
+GLIBC_2.31 totalorderf32 F
+GLIBC_2.31 totalorderf32x F
+GLIBC_2.31 totalorderf64 F
+GLIBC_2.31 totalorderl F
+GLIBC_2.31 totalordermag F
+GLIBC_2.31 totalordermagf F
+GLIBC_2.31 totalordermagf32 F
+GLIBC_2.31 totalordermagf32x F
+GLIBC_2.31 totalordermagf64 F
+GLIBC_2.31 totalordermagl F
stffrdhrn commented 4 years ago

ALL RESOLVED

After updating a few check-abi-* issues the report is was follows:

Long running

Known Issue

Fixed

Malloc

stffrdhrn commented 4 years ago

After fixing that, there was an issue with the __old_semctl function still being compiled and causing a compile failure due to missing __NR_ipc. I found we needed to define a shlib-version file to force the version compatibility. This required recompiling and there is now a new set of failures.

FAIL math/test-double-acos
FAIL math/test-double-asin
FAIL math/test-float32x-acos
FAIL math/test-float32x-asin
FAIL math/test-float64-acos
FAIL math/test-float64-asin
FAIL math/test-ldouble-acos
FAIL math/test-ldouble-asin

Chroot Issue

Known Issue

ABI Changes

stffrdhrn commented 4 years ago

Version 1 pushed upstream. closing this for now.