search

openrisc / orpsoc-cores

Core description files for FuseSoC
123 stars 78 forks source link

Atlys: Add or1200 core. #78

Closed heshamelmatary closed 10 years ago

heshamelmatary commented 10 years ago

fusesoc won't compie atlys system built with or1200 core instead of mor1kx. This patch add or1200 to be fetched if defined and uncomment needed file which is or1200_defines.v.

olofk commented 10 years ago

Thanks for this. There is unfortunately a structural problem with this. By using or1200_defines.v from or1200, we can't override any or1200 parameters in the Atlys port. What we have been doing for the other board ports is to keep a copy of or1200_defines.v in the atlys port instead so that we are free to make local modifications to that.

The better solution, as is done in mor1kx is of course to use parameters instead, but I don't expect anyone to go through that effort for or1200

So an updated patch that puts a local version of or1200_defines.v in the atlys port would make me a very happy submitter

heshamelmatary commented 10 years ago

Thanks for making this clear. I have added or1200_defines.v locally, and fusesoc is built successfully. with or1200 core now. Please have a look.

olofk commented 10 years ago

Thanks. That looks good. Applied