Fix event forwarding - Githubissues

openrm / hato

A minimalist, customizeable AMQP framework in Node.js

MIT License

1 stars 0 forks source link

Fix event forwarding #32

Closed naggingant closed 4 years ago

naggingant commented 4 years ago

Fixes three bugs with event forwarding:

the wrapper class in duplex plugin was breaking event propagation
the helper function to patch events through two emitters had an invalid code inside
there was a potential infinite loop regarding this

The helper is actually fundamental to our plugin system, as wrapper classes must not block any event either from the underlying event emitter, or from the end-users

naggingant commented 4 years ago

The issue emerged as we wrapped the event emitter implementations of channels, connections several times in the plugins. I decided to forward events in a bidirectional manner, in order to prevent any potential issue.

But this decision might have been wrong because we probably just need to proxy the events from the underlying emitter to the outside :thinking: When we can eventually conclude so, this fix isn't needed anymore.

PuKoren commented 4 years ago

Ok, I think we can keep it undocumented for now then