search

openrndr / orx

A growing library of assorted data structures, algorithms and utilities for OPENRNDR
https://openrndr.org
BSD 2-Clause "Simplified" License
121 stars 37 forks source link

@XYParameter does not show label #107

Closed hamoid closed 2 years ago

hamoid commented 4 years ago

Describe the bug Not sure if bug or feature request, but the @XYParameter in gui does not show the label

To Reproduce Use @XYParameter

Expected behavior Shows the label

Screenshots (the label is from the previous control)

Context:

Original control by @reinvdwoerd

goudreinette commented 4 years ago

Thanks for reminding me of this!

goudreinette commented 4 years ago

No half work, I'll fix it tonight! 😅

goudreinette commented 4 years ago

Is it ok if I add a demo for it in orx-panel? Or is it better to put that in orx-parameters or orx-gui? I think I'll put the demo for XYParameter in orx-gui.

hamoid commented 4 years ago

Demo for XYParameter in orx-gui sounds good to me :)

goudreinette commented 4 years ago

stream of consciousness writing 😂

Is it ok if I add a demo for it in orx-panel? Or is it better to put that in orx-parameters or orx-gui? I think I'll put the demo for XYParameter in orx-gui.

goudreinette commented 4 years ago

Does this look ok?

Screenshot 2020-05-17 at 20 01 26
goudreinette commented 4 years ago

No wait, that description is confusing. Let's just call it "Settings"

goudreinette commented 4 years ago

https://github.com/openrndr/orx/pull/108

hamoid commented 4 years ago

Have you looked how it looks together with other gui elements? It seems like they often have the label under, on the left. But as you did it occupies less space...

Maybe you can take a screenshot with several inputs at once to see how they blend together?

goudreinette commented 4 years ago

Good idea

goudreinette commented 4 years ago

It does look a little inconsistent

Screenshot 2020-05-17 at 21 55 29
goudreinette commented 4 years ago

Especially the spacing is off

goudreinette commented 4 years ago

I could make a few variations tomorrow...

goudreinette commented 4 years ago

This could be an alternative

Screen Shot 2020-05-19 at 8 57 15 PM
goudreinette commented 4 years ago

Or this

Screen Shot 2020-05-19 at 9 00 47 PM

In both cases the label might overlap with the values when either the label is long or the values have a high precision...

hamoid commented 4 years ago

Last one is my favorite. Not sure how to deal with the overlap... What if the numbers are in the grid but the label below it? anotheroption

hamoid commented 3 years ago

Hi hi :) Do you still have the code laying around? Would be nice to close this before its 1 year anniversary :-P Cheers!

goudreinette commented 3 years ago

Heyyy Abe! I wiped my hard drive a few times this year, but let me check if I still have it in a repository somewhere...

hamoid commented 3 years ago

You did that for fun or by accident? :)

goudreinette commented 3 years ago

It probably had something to do with a Hackingtosh update, which I was running at the time. But yeah it appears that I deleted my fork, but it shouldn't be so hard to recreate it, I definitely won't let it reach it's one-year anniversary

hamoid commented 2 years ago

Closing. The original issue was about a missing label, but the label is already there. Also sent a PR to implement what we discussed above :)