openrndr / orx

A growing library of assorted data structures, algorithms and utilities for OPENRNDR
https://openrndr.org
BSD 2-Clause "Simplified" License
119 stars 35 forks source link

orx-kinect refactoring + new general orx-depth-camera #257

Closed morisil closed 1 year ago

morisil commented 1 year ago

I changed a lot with this PR and unfortunately I couldn't keep down compatibility:

hamoid commented 1 year ago

Hi :) Is it expected that orx-depth-camera and orx-depth-camera-calibrator could be used independently? Or always together? Just wondering if the second could be part of the first (since it seems to be only one file) to avoid creating more orx'es than needed.

Great job, looks like very useful for all of you using depth cameras :)

morisil commented 1 year ago

@hamoid My intent was to make orx-depth-camera as an API independent from the implementation, therefore it's MPP module, potentially capable of supporting something like webcam from the browser with some ML depth estimation. The calibrator is dependent on orx-parameters and the logic of storing parameters between program runs, which works only on jvm, even though orx-parameters is technically MPP, but making it work in JS would require, I believe, providing some form of annotation processor, as reflection is not suppoorted. So I can see use cases of these 2 being used independently. But technically it would be possible to merge them, as orx-parameters is a MPP module, even if it's not fully implemented.

morisil commented 1 year ago

@hamoid , ok, just checked, not possible at the moment because orx-depth-camera-calibrator depends on :orx-jvm:orx-gui :( Once we have JS version of GUI, which I would be actually happy to have, then it can be merged.

hamoid commented 1 year ago

Thank you for trying! :-)