Minor performance improvements

openrr / urdf-rs

URDF parser for Rust

Apache License 2.0

30 stars 11 forks source link

Minor performance improvements #14

Closed taiki-e closed 3 years ago

taiki-e commented 3 years ago

~~Reduce allocation in deserialize functions~~ EDIT: see https://github.com/openrr/urdf-rs/pull/14#issuecomment-772233997
Use copy_from_slice instead of for-loops, see https://rust-lang.github.io/rust-clippy/stable/index.html#manual_memcpy for details
Remove needless clone

taiki-e commented 3 years ago

hmm....

thread 'funcs::it_works' panicked at 'called `Result::unwrap()` on an `Err` value: UrdfError(Xml(Custom { field: "invalid type: string \"0 0 0\", expected a borrowed string" }))', src/funcs.rs:160:36

taiki-e commented 3 years ago

hmm....

thread 'funcs::it_works' panicked at 'called `Result::unwrap()` on an `Err` value: UrdfError(Xml(Custom { field: "invalid type: string \"0 0 0\", expected a borrowed string" }))', src/funcs.rs:160:36

looks like https://github.com/RReverser/serde-xml-rs/issues/70

I'll remove the first commit