search

openrr / urdf-rs

URDF parser for Rust
Apache License 2.0
30 stars 11 forks source link

`Option` type for optional tags #2

Closed neachdainn closed 4 years ago

neachdainn commented 4 years ago

Currently, any optional URDF tags are represented by providing default values. Unfortunately, this makes it difficult to distinguish between times when the URDF is using the tag but has default values versus it just being a default value.

An example of this would be the safety controller: there is currently no way to distinguish if there are safety limits present or not. Ignoring safety values, even if the default, is likely bad form and potentially physically dangerous.

neachdainn commented 4 years ago

I am willing to work on this myself.

OTL commented 4 years ago

I think your suggestion is reasonable. I'm happy if you help about it.

neachdainn commented 4 years ago

Are there any version constraints you would like upheld or should I also update to the latest Rust idioms (e.g., using err.to_string() instead of err.description())?

OTL commented 4 years ago

Talking about error handling, I'm using thiserror crate.

https://github.com/OTL/k/blob/master/src/errors.rs

I think we can update every dependencies.

neachdainn commented 4 years ago

Using 2018 edition is fine as well?

OTL commented 4 years ago

Sure. I prefer 2018.

2020年7月15日(水) 13:17 Nate Kent notifications@github.com:

Using 2018 edition is fine as well?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OTL/urdf-rs/issues/2#issuecomment-658535864, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABSSJSW2DLCGNGHOWMW243R3UUWNANCNFSM4OZ3VXQQ .

-- /***** Takashi Ogura (小倉 崇)

t.ogura@gmail.com *****/