openrr / urdf-rs

URDF parser for Rust
Apache License 2.0
30 stars 11 forks source link

Add support for passing arguments to xacro files #60

Closed JafarAbdi closed 1 year ago

JafarAbdi commented 1 year ago

Currently, there's no way to load a xacro file that expects command line arguments.

convert_xacro_to_urdf expects only a filename, changing the signature is an API breaking change, do you have a better solution or are you ok with breaking the API?

I'm more than happy to implement it!

OTL commented 1 year ago

Hi,

I do not like to change API, but you can add new API like *_with_args. Does it works in your case?

2023年2月12日(日) 6:45 Jafar @.***>:

Currently, there's no way to load a xacro file that expects command line arguments.

convert_xacro_to_urdf https://github.com/openrr/urdf-rs/blob/main/src/utils.rs#L10-L30 expects only a filename, changing the signature is an API breaking change, do you have a better solution or are you ok with breaking the API?

I'm more than happy to implement it!

— Reply to this email directly, view it on GitHub https://github.com/openrr/urdf-rs/issues/60, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABSSJVTIG7WOKWPMOEXXBLWXAB63ANCNFSM6AAAAAAUY5H6HM . You are receiving this because you are subscribed to this thread.Message ID: @.***>