It's probably best to step through each commit when reviewing this PR, as I've tried to summarize my rationale step-by-step. Essentially, rather than fixing convert_config, I've replaced it. We lose some functionality, but I don't think we need it now that reusable actions are built into job-runner. As a consequence, there's now less production code.
I've used mock.patch in intermediate commits, but you'll see that ultimately I remove it entirely. I am definitely now an adherent of the classical school 🎒.
It's probably best to step through each commit when reviewing this PR, as I've tried to summarize my rationale step-by-step. Essentially, rather than fixing
convert_config, I've replaced it. We lose some functionality, but I don't think we need it now that reusable actions are built into job-runner. As a consequence, there's now less production code.I've used
mock.patchin intermediate commits, but you'll see that ultimately I remove it entirely. I am definitely now an adherent of the classical school 🎒.Fixes #48