opensafely-actions / cohort-report

Cohort-report generates a report for each variable in an input file
MIT License
0 stars 0 forks source link

Fix the extract from project.yaml #68

Open iaindillingham opened 2 years ago

iaindillingham commented 2 years ago

The extract from project.yaml does not include the charts in outputs/moderately_sensitive. It should, otherwise the report will not include the charts.

test-reusable-actions has a better example:

# ...
  test_cohort_report:
    run: cohort-report:v2.1.0 output/input.csv
    needs: [generate_study_population]
    config:
      output_path: output
      variable_types:
        sex: categorical
        age: int
        age_band: categorical
        has_copd: binary
    outputs:
      moderately_sensitive:
        cohort_report: output/descriptives_input.html
        cohort_report_charts: output/*.png
iaindillingham commented 2 years ago

Thanks for reporting, @andrewscolm.

sebbacon commented 2 years ago

IIRC in the original version of the reporter tool we got round this by making images inline/base64 -- is that an option you considered Iain?

iaindillingham commented 2 years ago

I hadn't; it's a good idea. I'm not sure how magical this would seem to a researcher. Rhetorical question: If a researcher wanted just the images, rather than the images embedded in a report, then how easy would it be to extract them?