opensafely-core / airlock

Other
0 stars 0 forks source link

Check before setting APPROVED status #399

Closed bloodearnest closed 1 month ago

bloodearnest commented 1 month ago

Currently, if a user has to retry a approving a release (e.g. because the job-server request failed), then because we've already set the state to APPROVED before attempting the upload, airlock blows up, an the request is effectively blocked

We should only set status to APPROVED it its not already APPROVED, to avoid this blockage.