Disable editing of context and controls for author when the request is under review

opensafely-core / airlock

Other

1 stars 0 forks source link

Disable editing of context and controls for author when the request is under review #538

Closed rebkwok closed 1 month ago

rebkwok commented 1 month ago

Disable editing of context/controls for author when the request is under review Fixes #537

Hide comments unless allowed to comment Fixes #539 Commenting is only allowed if a request is

not final
is under review, and the user is an output-checker
is in draft, and the user has permission to accesss the workspace

rebkwok commented 1 month ago

Yeah, I spent a while trying to come up with a decent name for it. in_progress isn't specific enough, is_editing and is_under_edit sounded weird, and didn't really feel like they covered the PENDING stage. Is is_editing better that is_in_draft?

bloodearnest commented 1 month ago

Yeah, I spent a while trying to come up with a decent name for it. in_progress isn't specific enough, is_editing and is_under_edit sounded weird, and didn't really feel like they covered the PENDING stage. Is is_editing better that is_in_draft?

yeah, I think its a bit better if you feel like making the change.