Filter audit logs for visibility - Githubissues

opensafely-core / airlock

Other

1 stars 0 forks source link

Filter audit logs for visibility #583

Closed bloodearnest closed 1 month ago

bloodearnest commented 1 month ago

This is an identical resubmission of https://github.com/opensafely-core/airlock/pull/570

I accidentally merged that then reverted. This is that with clean history, and rebased on all the main change since then.

Factor out the core visibility logic to be reusable
Remove activity log from workspace.
Switch tests that assert against audit logs to use the DAL
Rename get_audit_log to get_request_audit_log
Filter audit logs by visibility
Cover the new filtered audit logs in tests
Clarify filter_visible_items logic
Rename CommentVisibility to Visibility
Fix visible logic when phase is COMPLETE
Fix bug in comment descriptions and class
Refactor the comment visiblity pills
Fix comment typos