opensafely-core / backend-server

Infrastructure code for managing partner hosted opensafely backend servers.
0 stars 2 forks source link

TPP airlock deployment directory permission issues #213

Closed madwort closed 6 months ago

madwort commented 6 months ago

@madwort needed to manually run

chown opensafely:opensafely ~opensafely/airlock/workdir

when deploying on TPP, although this is not currently necessary in the lxd/CI tests. It would be useful to figure out why & fix...

madwort commented 6 months ago

ah yes, so this works in tests because we re-run just manage & we have this open-ended chown -R. So in testing the second time through the manage scripts we set the ownership on ~/airlock/workdir correctly & then tests pass.

The fix is easy - just add mkdir -p workdir before the chown -R, but the more abstract problem of re-running of the script giving different results second time is less obvious to do something about (in the short term).