Rename database column to demonstrate a working MappedTable

opensafely-core / ehrql

ehrQL: the electronic health record query language for OpenSAFELY

https://docs.opensafely.org/ehrql/

Other

7 stars 3 forks source link

Rename database column to demonstrate a working MappedTable #2156

Closed madwort closed 2 weeks ago

madwort commented 2 weeks ago

wanted to see this to verify that MappedTable::validate_against_table_schema() was functioning as expected
the use of set(self.column_map) looked wrong to the untrained eye, but is actually correct
do the same mapping as the QueryTable test

cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying databuilder-docs with Cloudflare Pages

Latest commit:	`71fdb0f`
Status:	✅ Deploy successful!
Preview URL:	https://20d55e22.databuilder.pages.dev
Branch Preview URL:	https://madwort-dob.databuilder.pages.dev

View logs

madwort commented 2 weeks ago

ah, it looked wrong because dictionaries iterate over their keys - I thought that the schema it was being compared to was the database schema (DoB) & couldn't understand how it was working (and then it looked like it wasn't covered by a test...)