search

opensafely-core / interactive-templates

Code to generate the reports generated by OpenSAFELY Interactive
Other
0 stars 0 forks source link

Specify tag in job-server PR workflow #377

Closed StevenMaude closed 3 months ago

StevenMaude commented 3 months ago

See also #118.

This largely fixes the "create a PR in the job-server repository" workflow.

The existing token is currently expired, so the workflow now fails due to that, which is just about the last step of creating a PR.

However, it may be better to do as ehrQL does and actually move this workflow to the repository where the PR is getting created, then check for updates for interactive-templates. The only drawbacks:

I'm not sure that's such a problem when the number of updates is so infrequent here. It does remove all the hassle of dealing with tokens (as in ebmdatalab/metrics#194).

I'll include these fixes here for reference in any case.

StevenMaude commented 3 months ago

Closing as we're now handling this process in job-server.

See opensafely-core/job-server#4442.