search

opensafely-core / job-server

A server for mediating jobs that can be run in an OpenSAFELY secure environment. q.v. job-runner
https://jobs.opensafely.org
Other
5 stars 10 forks source link

Support svg.gz in outputs viewer #2099

Open bloodearnest opened 2 years ago

bloodearnest commented 2 years ago

Users like .svg files as an export format. However, they can get very large, too large to release.

.svgz or .svg.gz formats are much smaller, but cannot currently be viewed in the outputs viewer. It would be could to add support for them.

In concert, it would be good to update the releasing docs to encourage compressed svg

sebbacon commented 2 years ago

Just to say, we have talked before about requiring images to be bitmaps, because SVGs can more easily leak identifiable information. Did a decision get made at some point that this is an acceptable risk, do you know?

bloodearnest commented 2 years ago

I don't think so. Surely the same problem applies to HTML?

The reviewers look at the rendered output only in both cases.

sebbacon commented 2 years ago

This is a fair question. You could argue SVG is different because as I understand it many libraries include loads of granular data by default even in aggregated views. But I don't really know, and I don't have a view on the answer.

The reason for asking the question is that I know there have been questions like this, and it makes me think we should probably be careful to make (and capture) decisions about file types with the output-release team or experts (like @LFISHER7).

LFISHER7 commented 2 years ago

I don't think we explicitly made a call against SVGs. We ask for the underlying data for any figures when output checking but there's a certain amount of trust that that is what is being plotted. We can certainly encourage bitmaps as the preferred format in the docs. A big part of this is allowing the flexibility to meet the various requirements of journals.