search

opensafely-core / job-server

A server for mediating jobs that can be run in an OpenSAFELY secure environment. q.v. job-runner
https://jobs.opensafely.org
Other
5 stars 10 forks source link

Fix missing info box title on UserDetailWithOAuth page #4044

Closed ghickman closed 6 months ago

ghickman commented 6 months ago

We have two info boxes for missing data on the UserDetailWithOAuth page, selectively showing if a user is missing link(s) to a Backend, Org, or Project. One of the boxes handles Orgs and Backends, and its title is incorrectly set to "No projects".

Related to this, I can't remember why we split this into two boxes. @tomodwyer or @lucyb might know?

lucyb commented 6 months ago

I don't know. One box would seem to make more sense.

tomodwyer commented 6 months ago

Nope, no idea why we did that 🤷

ghickman commented 6 months ago

Given no-one can remember why we split them up, I think the pragmatic choice here is to merge them, and set a generic title on the card 👍

Jongmassey commented 6 months ago

edit: ignore below, I'm just flapping, I think I've got a wording that works

--

Merging the current explanatory texts

A user requires access to certain resources to be able to use the Jobs site. The following are missing for this user: [...] If you think this is incorrect, please speak to the IG Team.

and

A user would ideally have access to one or more Projects.

doesn't really fit as the suggested action for the former doesn't really apply to the latter?