search

opensafely-core / job-server

A server for mediating jobs that can be run in an OpenSAFELY secure environment. q.v. job-runner
https://jobs.opensafely.org
Other
5 stars 10 forks source link

Remove `attrs` #4532

Closed StevenMaude closed 2 weeks ago

StevenMaude commented 1 month ago

Similar to #4491, we could consider removing attrs.

It's used in a few places. However, from a quick look, it doesn't seem like we often use much additional functionality over that which Python's dataclasses provide.

(This was prompted by reviewing #4531 and wondering what we used attrs for.)

StevenMaude commented 3 weeks ago

This is actually dependent on interactive-templates; that depends on attrs too.

If we ever remove the use of interactive-templates, we can completely remove attrs as a dependency. In the meantime, we can clean up the uses of it in the job-server code directly.

StevenMaude commented 3 weeks ago

4456 is the first part of this.

iaindillingham commented 2 weeks ago

As #4556 is merged, and as completely removing attrs is wrapped up in removing interactive-templates, I'm going to close this issue.