search

opensafely-core / job-server

A server for mediating jobs that can be run in an OpenSAFELY secure environment. q.v. job-runner
https://jobs.opensafely.org
Other
5 stars 10 forks source link

Remove unused "Level 4 file viewer" code #4588

Open evansd opened 1 week ago

evansd commented 1 week ago

Previously, we had a system for viewing unreleased output files which involved users logging in to Job Server from within Level 4 (using a single-use token) and then using a "hybrid" JavaScript app which combined a remote UI with file data from a local API. This allowed viewing unreleased files without that data every leaving the secure environment.

Airlock replaces this wholesale by running the entire application within the secure environment.

This PR updated the UI to replace references to the old system with references to Airlock:

However it left in place of lot of now redundant code which should be cleaned up. A few examples are:

Note that the single-use token API endpoint needs to remain as this is used by Airlock. As therefore does the single-use token generator UI. It's just logging in to Job Server itself using the token which is no longer supported.

Note also the the file viewer SPA needs to remain for now as this is used for viewing released output files. Longer term there's an ambition to replace this with something simpler.

Related Slack thread: https://bennettoxford.slack.com/archives/C069YDR4NCA/p1725463761914569

iaindillingham commented 1 week ago

Thanks, @evansd. I think this is an issue for 🦖, so I've added it to the board. If you think differently, then let me know!

evansd commented 1 week ago

Ah, thanks @iaindillingham. You're absolutely right that this is natural :t-rex: territory. I've just added a link to the associated Slack thread where we discussed this. Because I started pulling on this particular thread, and because it's motivated by Airlock, it's possible I'll take it on. Or some of it at least.

inglesp commented 1 week ago

Will any documentation changes be required?

lucyb commented 1 week ago

Will any documentation changes be required?

I expect any user-facing documentation will have been updated as part of the Airlock work. Although, that said, this page in the team manual should be updated, but as part of the Airlock work rather than this ticket.

Otherwise, I've had a look and I can't see any documentation that should be updated as part of this ticket.