search

opensafely-core / job-server

A server for mediating jobs that can be run in an OpenSAFELY secure environment. q.v. job-runner
https://jobs.opensafely.org
Other
5 stars 11 forks source link

New job on EMIS backend fails with "Invalid database name '', allowed are: full, slice, dummy" #593

Closed inglesp closed 3 years ago

inglesp commented 3 years ago

See https://jobs.opensafely.org/jobs/yf4pv4qkp45qmvfb/

ghickman commented 3 years ago

This was caused by the changes in #584, however @inglesp has also raised the question of having the db field at all. Given we only support one option, full, for new workspaces, is there a need to keep using field? I think we probably want to keep the field for legacy workspaces, particularly those which have used the slice db, but is it worth the job-server API/job-runner/cohort-extractor(?) stopping use of the field?

@evansd and @sebbacon – you're probably best placed to answer this?

evansd commented 3 years ago

@bloodearnest might have useful views here as well.

My instinct is that we should get rid of it. Though we will need job-server to keep returning a value in the field until we can update the NHSD backend.

ghickman commented 3 years ago

Closing this since the original issue is fixed and we're talking about larger changes in #843