search

opensafely-core / opencodelists

OpenCodelists is an open platform for creating and sharing codelists of clinical terms and drugs.
https://www.opencodelists.org
Other
31 stars 11 forks source link

Server Error (500) for newly created Haematological malignancies codelist #1057

Closed rose-higgins closed 2 years ago

rose-higgins commented 2 years ago

I created this codelist today and on submitting received an error. It looks like the codelist exists within the NHSD codelist directory, however the page leads to a Server Error (500) page https://www.opencodelists.org/codelist/nhsd/haematological-malignancies-snomed/1583b91d/

inglesp commented 2 years ago

Sentry.

There's a KeyError when we look up the type of 1090241000000100, because we don't know anything about 1090241000000100. That's because the code should be 1090241000000107 and it looks like Excel's been playing its tricks again.

We're supposed to check that all codes are valid when a codelist is created, and I'm not sure why that's not happened here.

For now, I'll fix the the codelist in our database.

Somebody from the team (@rose-higgins?) should get in touch with whoever at the NHS published the codelist to let them know that there's a mistake.

inglesp commented 2 years ago

I'm not sure why that's not happened here.

This is because the codelist was created via the "secret" upload link, which doesn't do any validation.

inglesp commented 2 years ago

In fact, there are three bad codes:

code correct code term
1090241000000100 1090241000000107 Angioimmunoblastic T-cell lymphoma with dysproteinaemia (disorder)
1091891000000100 ? ?
1091921000000100 1091921000000103 B-cell non-Hodgkin's lymphoma (disorder)

I cannot find 1091891000000100 in this codelist, so I'm not sure what it should be.

inglesp commented 2 years ago

@rose-higgins, I'm going to delete the codelist. In your CSV file, please could you correct the two problematic codes in the table above, and make a decision about what to do with 1091891000000100. (If you know what term it is supposed to have, you can search for it in the NHS Term Browser.)

Then, when you upload it, could you do so via the "My Codelists" button, rather than via the secret URL? The description of the to-be-deleted codelist is "Taken from the GPES Rule 4 tab on the Haematological cancer code set, created by NHS Digital for the Shielded Patients List, published on 2021-10-01." All other metadata fields are blank.

inglesp commented 2 years ago

All other metadata fields are blank.

This was a lie, there was one reference. Unfortunately, I have deleted it!

inglesp commented 2 years ago

Here's the original CSV data, if useful.

haematological-malignancies-snomed.csv

rose-higgins commented 2 years ago

Thanks Peter! I have updated the codes you mentioned (and found the one relating to B-cell Hodgkin's lymphoma, phew.