search

opensafely-core / opencodelists

OpenCodelists is an open platform for creating and sharing codelists of clinical terms and drugs.
https://www.opencodelists.org
Other
31 stars 11 forks source link

Not remembering my choices when building lists #704

Open Protocols-For-Research opened 3 years ago

Protocols-For-Research commented 3 years ago

Hi,

Here's my problem...

Scenario: When building lists I select all of the items returned by the search as positive or negative. I know I have done this because a) I have just done it b) the counter at the top left of the screen says there are no more unresolved codes.

Problem: When I then click over to look at the conflicts loads of unresolved codes reappear. It has't remembered my choices and I'm forced to do a load of them again. And again. Etc

This also happens if I click save changes.

What I think is going on - It's just really slow to save the list (don't ask me why!).

Why I think this - If I leave the page for a few mins before saving, it doesn't happen.

Cheers, Joe

inglesp commented 3 years ago

Hi Joe, thanks for raising this here. Do you have a link to a codelist where you're seeing this behaviour?

Protocols-For-Research commented 3 years ago

Hi Peter, thanks for the swift interest! it's my one codelist Respiratory Infection Snowmed https://codelists.opensafely.org/builder/6463fc2f/ - https://codelists.opensafely.org/builder/6463fc2f/

It's still doing it, despite my leaving the page for a bit...

Cheers,

Joe :)

On Tue, May 11, 2021 at 4:29 PM Peter Inglesby @.***> wrote:

Hi Joe, thanks for raising this here. Do you have a link to a codelist where you're seeing this behaviour?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opensafely-core/opencodelists/issues/704#issuecomment-838682512, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC5UXLVE7F4NRZ6FNSDSY3TNFEMDANCNFSM44V2RVAA .

inglesp commented 3 years ago

Thanks, that's helpful. I think I know what the problem is, and will prioritise a fix this week. (You're dealing with a large number of concepts, and the software is doing much more work than it needs to in order to handle this. I'm going to add some caching.)

In the meantime, could you hold off making any more changes?

Protocols-For-Research commented 3 years ago

That’s great, thank you! I’ll hold off and work on some shorter lists!

Joe 😀

On 11 May 2021, at 17:06, Peter Inglesby @.***> wrote:

 Thanks, that's helpful. I think I know what the problem is, and will prioritise a fix this week. (You're dealing with a large number of concepts, and the software is doing much more work than it needs to in order to handle this. I'm going to add some caching.)

In the meantime, could you hold off making any more changes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

inglesp commented 3 years ago

We've made some changes that should make the site behave a bit better for large codelists. Can you let me know how you get on?

Protocols-For-Research commented 3 years ago

Hi Peter,

Thanks! I'll try again with the big list.

Sorry - I've just reported another problem - not opening the sublists when clicking on them - and this seems to be for quite a small list (oral steroids). Again it seems to be slowly doing it sometimes, or on refreshing...?

Thanks again

Joe :)

On Thu, May 13, 2021 at 1:19 PM Peter Inglesby @.***> wrote:

We've made some changes that should make the site behave a bit better for large codelists. Can you let me know how you get on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opensafely-core/opencodelists/issues/704#issuecomment-840518654, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC5UXI4AWKWD7VTA5NEUF3TNO7UXANCNFSM44V2RVAA .

Protocols-For-Research commented 3 years ago

I think the website still can't handle big codelists - this is a problem as it's not always possible to do small ones.

For example I'm trying to do a list for CVD, but the search for the single term 'cardiovascular' returns over 20k codes

https://www.opencodelists.org/builder/66469f99/

The site is very slow or freezes and gives: Error code: RESULT_CODE_HUNG, for example if one tries to see the unresolved codes only. :(

inglesp commented 3 years ago

Sorry you're finding this frustrating. I'm on leave for the next week, but will take a look when I return.

Protocols-For-Research commented 3 years ago

No worries, thank you!

On 18 Jun 2021, at 20:29, Peter Inglesby @.***> wrote:

 Sorry you're finding this frustrating. I'm on leave for the next week, but will take a look when I return.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

sebbacon commented 3 years ago

Hi Joe - CTO of opensafely here - I just wanted to let you know I'm afraid we're not going to have the resources to fix this for a few weeks - @inglesp has been pulled into a different project. Unfortunately for you, you're the only person who's needed to make really large codelists so far. Is this an urgent project? Do you have workarounds you can live with?

Protocols-For-Research commented 3 years ago

Thanks for letting me know. I’ll try other approaches.

On 9 Jul 2021, at 15:59, Seb Bacon @.***> wrote:

 Hi Joe - CTO of opensafely here - I just wanted to let you know I'm afraid we're not going to have the resources to fix this for a few weeks - @inglesp has been pulled into a different project. Unfortunately for you, you're the only person who's needed to make really large codelists so far. Is this an urgent project? Do you have workarounds you can live with?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.