Open iaindillingham opened 7 months ago
Action tags are designed to work differently - the current version should be tagged v2 - its a moving tag.
When it was updated to add Liam, it HEAD was tagged v2 (as per README.md, its not a breaking changed). To bring it up to date we need to run make tag-release
, which will tag the current HEAD as v2.
We can also tag v2.1 if we want, but we should update v2 to point to v2.1. This is the convention for action tags: v2 points to the latest of v2.x.y.
Ah, that's really useful! Thank you, @bloodearnest.
We could also quickly fix the v1 action this way too.
If we branch from the v1 tag, change the names, then tag that branch as the new v1, we'll get the correct notifications w/o having to update all the repos.
Of course, we should probably do the work to update all the repos using v1 anyway, but the above is quick fix.
I've run make tag-release
, so if a study is run in CI, points to research-action v2 (in .github/workflows/test_runner.yaml
), and references a restricted dataset, then the agreed people will be notified.
In today's stand-up, we agreed to defer work on updating studies from v1 to v2 until we've created some guidelines for updating studies. We will likely need to update studies as part of the current Codespaces initiative.
Simon noticed^1 that many studies are using research-action v1. This version notifies the following users if a restricted dataset is referenced:
https://github.com/opensafely-core/research-action/blob/c1c04e8f8de82ea8764d99bcc9c0a65a3abba65d/action.sh#L52
The latest version is v2. This version notifies the following users:
https://github.com/opensafely-core/research-action/blob/dfd59edbcd71109c0f2e517d4b3a797155c9abca/action.yml#L9
Actions
.github/workflows/test_runner.yaml
Affected studies