Closed Jongmassey closed 3 weeks ago
I don't think that the documentation for adding Codespaces to a project needs updating The steps to update are the same, and there are still multiple files to copy across to a project.
If we need to describe the upgrade path, the simplest way to do so would be:
.devcontainer
in your project.PR to explain the upgrade path (which isn't documented):
I think merging the PRs above should be sufficient to close this issue.
Closing as the related PRs are now merged.
The research template
devcontainer.json
contains apostCreateCommand
setting andpostAttachCommand
setting. Currently the former calls.devcontainer/postCreate.sh
(which is included in the research template repo), and the latter starts rstudio server.If we wish to make changes to what happens on either of these events, then this currently requires making changes to the research template which:
devcontainer.json
work correctly togetherI propose that:
postCreate.sh
,requirements.in
and a newpostAttach.sh
are added to the image as part of the Dockerfiledevcontainer.json
postCreateCommand
andpostAttachCommand
settings call these scripts.postcreate.sh
andrequirements.in
are removed from the research template repositoryAcceptance criteria
Note: we should keep an eye on how long this work takes and maybe reconsider if it potentially takes us beyond 28th June.