search

opensafely-core / research-template-docker

This provides the devcontainer Docker image used by repos created from the OpenSAFELY research template.
Other
0 stars 0 forks source link

Add a workflow to test development Docker images #60

Open StevenMaude opened 3 weeks ago

StevenMaude commented 3 weeks ago

Adding this as a proposal only. If others think it's useful, we can merge or refine it. Otherwise, it's fine to close this PR.

This workflow build the Docker image for a branch. It then runs the dev container tests using that branch-built image, instead of the image specified in the research-template dev container configuration.

For recent PRs in this repository, I've found it useful to test Docker image changes in a dev container and confirm the tests still run. This helps to avoid a cycle of merge PR, publish an image, manually test the dev container and find it fails, to then have to fix up the image.

This workflow allows for manually triggering such a check. It is not scheduled to run on every commit, nor intended to do so.

StevenMaude commented 3 weeks ago

There is some repetition/overlap with the existing dev_container.yml workflow; as the workflows are short, it may not be a huge problem.

StevenMaude commented 3 weeks ago

CI failing because of Canonical's current issues.