search

opensafely-core / research-template-docker

This provides the devcontainer Docker image used by repos created from the OpenSAFELY research template.
Other
0 stars 0 forks source link

Inconsistent return values from `here::here()` #62

Closed iaindillingham closed 1 week ago

iaindillingham commented 2 weeks ago

@rose-higgins reports that R's here::here() function works differently in a Codespaces R environment than in a local R environment.^1 Whilst Rose and Will think the difference is likely because of a version mis-match, it would be useful to know whether the code Rose was updating was never intended to be executed within our R action image.

Timebox to 1-2 hours.

Jongmassey commented 1 week ago

it would be useful to know whether the code Rose was updating was never intended to be executed within our R action image.

AFAICT that Rmd file doesn't appear anywhere in project.yaml

Jongmassey commented 1 week ago

AFAICT the antibody-and-antiviral-deployment repo doesn't have our standardised devcontainer config or docker image so I'd have to install a particular version of R in the codespace - and I don't know which (nor the here version) were at play here.

Backing out of this after about 15 mins of digging

iaindillingham commented 1 week ago

Thanks for looking into this, @Jongmassey. I'm going to close because I don't think the code Rose was updating was ever intended to be executed within our R action image.

iaindillingham commented 1 week ago

here (the package) is at v0.1 on the R action image, but v1.0.1 on CRAN.

Jongmassey commented 1 week ago

Wow, that's quite old

Jongmassey commented 1 week ago

2017-old