opensafely / booster-effectiveness-autumn-2022

MIT License
1 stars 1 forks source link

code review 20220403 #1

Closed elsie-h closed 1 year ago

elsie-h commented 1 year ago

This repo implements analyses of the comparative (pfizer vs moderna) and relative (boosted vs unboosted) effectiveness of the autumn 2022 booster vaccines.

@wjchulme - could you please provide a code review? Most of the code is taken from repos that implement comparative OR relative analyses, but there are some changes to accommodate doing both at once.

For now, the analysis is restricted to 2 matching rounds, 2 outcomes, no subgroups, and three postbaseline cuts.

Actions are included for data processing, matching, table 1, and km and Cox models.

I've tried to minimise the number of large patient-level datasets being stored, so the process_postmatch is called from several other scripts.

wjchulme commented 1 year ago

Looks good! I've checked that everything runs. I've looked through the code and everything makes sense, though I might be over-familiar.

For the comparative models, the treatment variable is still called treated (taking values 0/1), which is fine but might be slightly confusing for released outputs.

I made some very minor changes as I was going along in #2 but these barely merit a second glance. The only important thing is the number of AZ vaccines to extract. Feel free to look and merge when you're happy.