search

opensafely / hydroxychloroquine-research

0 stars 1 forks source link

Update with new variables #14

Closed DarthCTR closed 4 years ago

DarthCTR commented 4 years ago

Lots of heavy lifting with getting data prepped for analysis.

PLEASE NOTE: I made some simple changes in study definition that need to be individually considered when merging to master, as master includes recent updates that Brian made. Some changes that Brian made need to overwrite what's in this branch, and vice versa. Happy to go over line by line if necessary. :)

Thank you!

DarthCTR commented 4 years ago

@CarolineMorton Thank you for your review. I don't think there's anything that needs to change at this stage. I will work with @brianmackenna to get the remaining variables needed into the study definition.

brianmackenna commented 4 years ago

Great timing - I just pushed hopefully last of NSAID study up and relatively clear day tomorrow. Will get working on this plus placeholders

CarolineMorton commented 4 years ago

Ok great. I won't approve until the issue with neuro is resolved but I will look at the other PR in the meantime @brianmackenna. If that is ok, and can be merged to master, then you should be able to pull master into this branch and solve some of the stuff here.

brianmackenna commented 4 years ago

What other pull request @CarolineMorton ? I can only see this one outstanding!

CarolineMorton commented 4 years ago

Oh you are right, what am i talking about? I think i was thinking of the NSAID study! Sorry @brianmackenna