search

opensafely / ics-research

This is the code and configuration for our paper, Inhaled corticosteroid use and risk COVID-19 related death among 966,461 patients with COPD or asthma
https://opensafely.org
0 stars 1 forks source link

Update study definition - ICS codes +vaccs #61

Closed brianmackenna closed 4 years ago

brianmackenna commented 4 years ago

Updated study definition

I can't see what is causing the failing tests....it is the COPD clinical codes which I don't think I touched......

CarolineMorton commented 4 years ago

There is this bug that I am not quite sure how to fix, but that I have been manually fixing where teh COPD codelist brings in an additional character in the CTV3ID column. This only happens when you run the python get_codelists.py command and grab a new csv. I have been manually deleting. I have checked the codelist online and the character is not in there so not sure where it is coming from. @inglesp may know.

CTV3ID

In the meantime, i have fixed manually.

alexwalkerepi commented 4 years ago

Have resolved conflicts, but worth checking @brianmackenna

inglesp commented 4 years ago

There is this bug that I am not quite sure how to fix, but that I have been manually fixing where teh COPD codelist brings in an additional character in the CTV3ID column. This only happens when you run the python get_codelists.py command and grab a new csv. I have been manually deleting. I have checked the codelist online and the character is not in there so not sure where it is coming from. @inglesp may know.

I've removed this funny character from the database.