opensafely / waning-ve-3dose

Estimating waning effectiveness of a third dose of covid-19 vaccine.
MIT License
0 stars 0 forks source link

Code review for study definition, data preparation and plotting vaccination dates #2

Open elsie-h opened 2 years ago

elsie-h commented 2 years ago

@wjchulme please could you review the main branch of this repo - if you want to suggest changes please create a branch.

Apologies for doing this as an issue rather than PR tracking changes compared to the original 2dose waning project - I was initially doing this but it got a bit messy with file name changes etc so I thought it better to merge and summarise the changes here.

A summary of changes:

Eligibility criteria a:

image
wjchulme commented 2 years ago

Runs, and looks good. I might steal some of those utility functions

elsie-h commented 2 years ago

Thanks! FYI I tidied up the scripts in the ggplot-extensions folder, as I was defining several ggplot2 internal functions unnecessarily (closed PR here).