Closed bgoorden closed 1 month ago
This is an excellent improvement, which prepares xdocreport for the modern era in Java development. Please merge this pull request.
You also could make separate Releases for Java 8
No time to do that, let's move to Java 17.
It seems that there is compilation error https://github.com/opensagres/xdocreport/actions/runs/8649808594/job/24797176532?pr=662#step:4:2072
@bgoorden CodeQL must be updated to Java 17 here, can you please update this PR: https://github.com/opensagres/xdocreport/blob/master/.github/workflows/codeql-analysis.yml
The "Java CI with Maven / build (pull_request)" is succesful.
@bgoorden Please update this PR, thank you.
We still want to compile to java 8 code for now right?
Java 17, please.
There is some build error here, I would appreciate if you would fix this please.
Once ci build wil be fixed we could merge this PR
I'm not getting those build errors on my fork. I updated the maven-bundle-plugin and java version configuration since the error seems to come from there.
LGTM, theCI build is working again, thanksso much @bgoorden !
There was already a pullrequest for 2.0.0, but this has some missing changes and failing tests. Since it was not updated for some time I made a new pull request to update to openPDF 2.0.2. (2.0.0 pull request: https://github.com/opensagres/xdocreport/pull/636 )
Update to OpenPDF 2.0.2:
https://github.com/opensagres/xdocreport/issues/635
OpenPDF require Java 17 or later from version 2.0.0 and later. Before the requirement was java 8. https://github.com/LibrePDF/OpenPDF/releases/tag/2.0.2 .
I removed the exclusions on bouncycastle. These exclusions are no longer dependencies of openpdf. Also the bouncycastle dependencies that are currently dependencies of openpdf are all optional.