search

opensandiego / mealscount-backend

Optimizing a free-meal reimbursement program for K-12 schools
MIT License
12 stars 15 forks source link

logos and rollovers #37

Closed FlorentinaMargarita closed 4 years ago

FlorentinaMargarita commented 4 years ago

insertet 3 logos, linked them to their respective webpages, inserted …

nikolajbaer commented 4 years ago

Thanks so much for the Pull Request!

So far it is looking good. Just 2 minor requests!

  1. It looks like you were going to link the logos in from the local src assets folder. Almost there! This is more reliable/secure/courteous! To do this, you will need to follow the WebPack guidelines for image assets:

https://webpack.js.org/guides/asset-management/#loading-images

The trick i think is to import them in the Home component script, then add them maybe as an object in the data section. You will probably need to add a Githubissues.

  • Githubissues is a development platform for aggregating issues.