Reader Package Deprecation Implementation(npm)

opensbom-generator / parsers

Language and ecosystem parsers

Apache License 2.0

6 stars 10 forks source link

Reader Package Deprecation Implementation(npm) #45

Open Ash-KODES opened 1 year ago

Ash-KODES commented 1 year ago

FIXES #15 Approach- Will try to implement all the method that uses the reader package and then refractor and deprecate the reader's methods. npm implementation for the deprecating package.

puerco commented 1 year ago

(btw we expect some tests to still fail as we are repairing them)

Ash-KODES commented 1 year ago

is fine but I want to make sure we strip the module.

Ok, So there are two occurrences for the reader package, yarn and npm I can make one PR for yarn and then and PR for Npm. since,I have made changes in npm rightnow so this PR would be now in context of npm now. Thanks.

Ash-KODES commented 1 year ago

[x] Squashed previous commits into major commit
[x] Added error messages
[x] npm methods done, reader import removed.

Ash-KODES commented 1 year ago

@puerco @nishakm Can you please give it a look?

Ash-KODES commented 1 year ago

@puerco @nishakm Can you please give it a look?

Can someone please review this PR?

nishakm commented 1 year ago

Hi @Ash-KODES, would it be possible for you to rebase your changes so we can test it?

Ash-KODES commented 1 year ago

Hi @Ash-KODES, would it be possible for you to rebase your changes so we can test it?

sure @nishakm

Ash-KODES commented 10 months ago

@puerco @nishakm Please Review, I have rebased it.

Ash-KODES commented 10 months ago

Hey Guys @nishakm @puerco ,I want to ask few questions regarding these projects,do we have a channel or how can i connect with you guys ? thanks & Regards