search

opensbom-generator / parsers

Language and ecosystem parsers
Apache License 2.0
6 stars 10 forks source link

test(poetry): unit tests for poetry #63

Closed ba11b0y closed 1 year ago

ba11b0y commented 1 year ago

Extends #62

ba11b0y commented 1 year ago

@nishakm @puerco Is this the right way to add unit tests for this one?

ba11b0y commented 1 year ago

Failing tests should get fixed once https://github.com/opensbom-generator/parsers/pull/65 is merged

puerco commented 1 year ago

Looking good :+1:

ba11b0y commented 1 year ago

The failing test seems to be working fine on my local machine. Any idea here? @puerco @nishakm

ba11b0y commented 1 year ago

The failing test seems to be working fine on my local machine. Any idea here? @puerco @nishakm

I forgot to install the dependencies using poetry 🤦 https://github.com/opensbom-generator/parsers/pull/63/commits/7bcb804b4bc237dc8ab64e3431d70ef30cb674ff fixes it

ba11b0y commented 1 year ago

Coverage increased to 79.7% from 0 for poetry

image

@puerco @nishakm Do you think this is good for starters?

nishakm commented 1 year ago

LGTM. I'm going to try squashing the commits to merge.