search

opensbom-generator / parsers

Language and ecosystem parsers
Apache License 2.0
6 stars 10 forks source link

fix: poetry gh actions #64

Closed ba11b0y closed 1 year ago

ba11b0y commented 1 year ago

Extends #63

ba11b0y commented 1 year ago

Unit tests for poetry would fail unless we setup poetry, this PR aims to add support for the same.

nishakm commented 1 year ago

@ba11b0y can you rebase your changes on top of main?

ba11b0y commented 1 year ago

@nishakm I've rebased the other branch on top of main

https://github.com/opensbom-generator/parsers/pull/63 This PR is based off of #63 to add support for gh actions. Which PR do you think should be merged first?

ba11b0y commented 1 year ago

@ba11b0y can you rebase your changes on top of main?

Done

nishakm commented 1 year ago

@ba11b0y can you rebase your changes on top of main?

Done

If you look at the commits you'll see there are 2 commits which are the ones I had squashed and merged. The last commit you had merged main into your branch. What I would like is for you to take 2 of your commits in the middle and place them on top of main.

I would recommend you set up your local git clone this way

ba11b0y commented 1 year ago

Yup I have the upstream configured. I merged instead of rebasing 🤦‍♂️ Should I go ahead and open a new PR with just the GitHub workflow fix?

ba11b0y commented 1 year ago

https://github.com/nishakm/puns#how-to-submit-prs-with-your-github-fork Nice read! Thanks for sharing!

ba11b0y commented 1 year ago

https://github.com/opensbom-generator/parsers/pull/65 adds support for poetry tests. Closing this