opensbom-generator / spdx-sbom-generator

Support CI generation of SBOMs via golang tooling.
403 stars 110 forks source link

Empty value for PackageVersion tag #63

Open swinslow opened 3 years ago

swinslow commented 3 years ago

Summary

Looking at some samples from running v0.0.5 (e.g. from running spdx-sbom-generator on itself), it looks like for the "primary" Package, the PackageVersion: tag appears but with no content on the line after it.

It looks like this validates when testing it on the SPDX Online Tools validator, but I believe this is an error in the online tools. Any tag should have content following it.

Steps to reproduce

Running spdx-sbom-generator on itself, and reviewing the output

Expected behavior

A PackageVersion: should be filled in, or at least should not be empty. Ideally, this could be provided in a couple of ways, if it can't be automatically derived from the project being analyzed:

Screenshots

See line 13 below:

image

Acceptance Criteria

A PackageVersion: line always has content following it, and is not an empty line

References

https://spdx.github.io/spdx-spec/3-package-information/#33-package-version

dealako commented 3 years ago

@swinslow - I assume this impacts the go module itself, so I will add the go label.