openscad / MCAD

OpenSCAD Parametric CAD Library (LGPL 2.1)
http://reprap.org/wiki/MCAD
578 stars 192 forks source link

involute_gears.scad has improper pitch check #108

Open SirNate0 opened 1 year ago

SirNate0 commented 1 year ago

Somehow the check got broken or out of order. The if statement would probably work fine if it were below the ternary operator setting the circular_pitch, or it should check for the diametral_pitch being undef as well.

https://github.com/openscad/MCAD/blob/bd0a7ba3f042bfbced5ca1894b236cea08904e26/involute_gears.scad#L321-L325