added a root rounding option to involute_gears

openscad / MCAD

OpenSCAD Parametric CAD Library (LGPL 2.1)

http://reprap.org/wiki/MCAD

578 stars 192 forks source link

added a root rounding option to involute_gears #17

Closed McNeight closed 4 years ago

hyperair commented 10 years ago

What's this for? I'm now seeing pinholes inside the gear which thoroughly screw up the helical and herringbone gear generation (twist>0).

hyperair commented 10 years ago

Oh wait, I see it now. Fixing..

hyperair commented 10 years ago

Please apply this as well after merging: https://github.com/hyperair/MCAD/commit/b61dea4

hyperair commented 4 years ago

I'm closing this -- the changes in this PR aren't sufficient to be merged (will break herringbone, helical, and 2D gears), but have been included in a functional form in the dev branch already.