search

openscad / MCAD

OpenSCAD Parametric CAD Library (LGPL 2.1)
http://reprap.org/wiki/MCAD
578 stars 192 forks source link

Updates to gear module in involute_gears.scad #29

Closed gizmoplex closed 4 years ago

gizmoplex commented 8 years ago

I fixed a couple problems in involute_gears.scad and made a few tweaks to default parameter values to make them more usable while I was at it. The problem that I ran into that prompted me to make these changes is that there were some problems in the pitch calculations. There were a couple places where 180 was used that should have been PI. It looks like it was a degrees vs. radians thing.

This is the first time I've done a pull request or attempted to contribute to an open source project. Hopefully I am doing this correctly.

Please consider my changes for inclusion into the openscad/MCAD repo.

Thanks!

capveg commented 7 years ago

@gizmoplex : thanks for the patch. I ran into these same problems myself but I'm new to the space so was wondering what I was missing. Did you ever hear back from the developers? Most of these changes seem fairly sane to me. You even went an split up your patches in to little mini-patches in a way that's much more conscientious than I (a professional software engineer; read: lazy) would have done. Good show!