Closed KjellMorgenstern closed 5 years ago
For the reasons described in issue #32 this kind of API-breaking change would have to go into dev
and not into master
. And for the same reasons might require renaming some of the modules. Otherwise the changes look reasonable.
Thanks for the hint, I'll review this against dev branch
The PR replaces the original teardrop.
This is a proposal for discussion, since it breaks the original parameters. Not backward compatible, so probably not acceptable. I would be interested to improve it based on feedback, or push it as a "teardrop2" module.
How and why?
Code explained: The teardrop is constructed in 2D as the hull of a circle and a dot above the circle. This is then extruded to 3D. The dot is placed in the exact distance that is needed to reach a desired slope. For example, if you can print 30 degree overhangs, min_a = 30 results in a teardrop that uses a flat slope of 30 degree.