rockstorm101
commented
5 years ago On July 30, 2019 5:02:06 PM GMT+01:00, Kjell notifications@github.com wrote:
A flat Nema17 motor (height 20.7mm) was added. It did not fit the "Short,Medium,Long" categories, so I added a "NemaFlat" category.
The shaft and grinded flat shape were black, but I think the are silver on most motors.
The mounting holes were refactored out into a module, so they can be easily used to add mounting holes to a custom build plate.
Before
After
You can view, comment on, or merge this pull request online at:
https://github.com/openscad/MCAD/pull/61
-- Commit Summary --
- Add 'flat' type for 21mm Nema17 steppers, fix silver color for shaft
- Refactor stepper for more flexible usage, e.g. cutout
-- File Changes --
M stepper.scad (131)
-- Patch Links --
https://github.com/openscad/MCAD/pull/61.patch https://github.com/openscad/MCAD/pull/61.diff
Hi Kjell,
Please don't take this personal, I'm sure this took quite a bit of time to make.
However, I think a library like MCAD is not the place for finished objects like these. The MCAD library should only contain tools and utilities to construct such objects. "Finished" objects should go into a separate repository. Which by the way would be a great idea. A big, "browseable" repository of already modelled commonly-used objects in OpenSCAD.
That being said, I would suggest removing 'stepper.scad' all together for future releases.
Of course this is just my opinion and I don't know what @hyperair might think about it.
KjellMorgenstern
A flat Nema17 motor (height 20.7mm) was added. It did not fit the "Short,Medium,Long" categories, so I added a "NemaFlat" category.
The shaft and grinded flat shape were black, but I think the are silver on most motors.
The mounting holes were refactored out into a module, so they can be easily used to add mounting holes to a custom build plate.
Before
After