Cleanup - Githubissues

openscad / MCAD

OpenSCAD Parametric CAD Library (LGPL 2.1)

http://reprap.org/wiki/MCAD

578 stars 192 forks source link

Cleanup #71

Closed Illusion65 closed 4 years ago

Illusion65 commented 4 years ago

I replaced the deprecated child() and assign() in the library. I also made a few changes while testing/validating my updates:

applying an operation to all children, rather than only the first
updating some modules to work properly (or as I think they should work - check multiply.scad commit 87cf713d25b5a1c5531040ce020c6e55c951f19)
also fixed deprecated warnings in regular_shapes.scad - see Issue #69

I tried to make the changes clear in each commit comment. Thanks for a great library!

Illusion65 commented 4 years ago

I just checked, the [0:$children-1] parameter is necessary for the center parameter to not become a syntax error (center cannot be the only parameter of children()). Odd.

Also, I parameterized to remove the if...else clause: 488b1ee54e2cea479b2b9f0603680ecc28eaacff

Final change for the day... Thanks!