search

openscad / docker-openscad

OpenSCAD-related docker files
BSD 2-Clause "Simplified" License
10 stars 10 forks source link

Fix compile by limiting jobs #9

Closed spuder closed 2 years ago

spuder commented 2 years ago

As discussed here

Fix compile script.

thehans commented 2 years ago

These docker files are used by our CI servers to build AppImages. Its good that you were able to fix the build on your end, but I don't think this should be merged unless the CI servers are also failing. The free CI services we use often have time limits (in wall time, not core time I believe), so limiting jobs when there is no existing problem could potentially cause builds to exceed such limits and fail.

t-paul commented 2 years ago

There's a new set of images (openscad/openscad) which is meant for public use and this script is building those (update to the script using buildx coming soon). I'm not sure the script really would target other uses than building the official versions. It might be better to improve the readme @spuder started to explain the docker build options directly.

Otherwise, I'd prefer to update those images to default to JOBS=1 and not hard code that into the script. On my good old build server, I can happily run 2 parallel arch builds withJOBS=4 and that's already quite slow for the cross builds.

If there's other ways of supporting more workflows, we can try to incorporate that. But with the available time resources that must not have an impact on overall time to maintain this. (We want to have some time left for actual OpenSCAD improvements after all :grinning:.)