search

openscanhub / fedora-infra

Deployment configurations for the Fedora infrastructure.
https://openscanhub.fedoraproject.org
GNU General Public License v3.0
1 stars 1 forks source link

Enable find-unicode-control #63

Closed siteshwar closed 1 month ago

siteshwar commented 1 month ago

find-unicode-control is currently disabled in production and may require some extra work before being enabled. This issue tracks enabling find-unicode-control in production.

kdudka commented 1 month ago

I would say that enabling the unicontrol csmock plug-in in OSH is easy. There is some technical debt related to unbundling the find-unicode-control script from csmock but that can be addressed later: https://github.com/csutils/csmock/blob/main/scripts/find-unicode-control.py

siteshwar commented 1 month ago

@kdudka Currently the default scan profile has this value set:

{"analyzers": "gcc,cppcheck,shellcheck", "csmock_args": "--gcc-analyze", "koji_profile": "koji"}

Shall I add unicontrol in the analyzers? Do I need to add anything else in the csmock_args?

kdudka commented 1 month ago

I would suggest to add also --unicontrol-notests --unicontrol-bidi-only, which is used by the internal OSH instance since we enabled unicontrol.

siteshwar commented 1 month ago

It has been enabled in production. Test scan: https://openscanhub.fedoraproject.org/task/4095/