openscd / open-scd-core

Apache License 2.0
5 stars 8 forks source link

Unable to use the latest open-scd-core release #111

Closed danyill closed 1 year ago

danyill commented 1 year ago

I thought I would update open-scd-core as perhaps it would solve some issues I have:

-        "@openscd/open-scd-core": "^0.0.1-rc2.8",
+        "@openscd/open-scd-core": "^1.0.0",

I removed my build (dist) folder and reinstalled fresh (removing node_modules). However I receive errors:

node_modules/@openscd/open-scd-core/mixins/Plugging.ts:4:31 - error TS2307: Cannot find module '../locales.js' or its corresponding type declarations.

4 import { targetLocales } from '../locales.js';
                                ~~~~~~~~~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:21:57 - error TS2307: Cannot find module './locales.js' or its corresponding type declarations.

21 import { allLocales, sourceLocale, targetLocales } from './locales.js';
                                                           ~~~~~~~~~~~~~~

Found 2 errors.

I think this means the package is somehow broken.

danyill commented 1 year ago

I should add that during the installation process this modifies my localization files which now begin like this:

+<trans-unit id="sbcdf43ebad9c5a3a">
+  <source>Something unexpected happened!</source>
+</trans-unit>
+<trans-unit id="s62b4f83c9503e1af">
+  <source>≥ <x id="0" equiv-text="${redo.length}"/> nodes changed</source>
+</trans-unit>
+<trans-unit id="s0731afca1ab76175">
+  <source><x id="0" equiv-text="${redo.node.nodeName}"/> moved to <x id="1" equiv-text="${redo.parent.nodeName}"/></source>
+</trans-unit>
+<trans-unit id="s83eaab546be4bfb9">
+  <source><x id="0" equiv-text="${redo.node.nodeName}"/> inserted into <x id="1" equiv-text="${redo.parent.nodeName}"/></source>
+</trans-unit>
+<trans-unit id="s0f8217f07c54b541">
+  <source><x id="0" equiv-text="${redo.node.nodeName}"/> removed</source>
+</trans-unit>
+<trans-unit id="s85a55e7007003cc2">
+  <source><x id="0" equiv-text="${redo.element.tagName}"/> updated</source>
+</trans-unit>
+<trans-unit id="s8f4be9f086eb530f">
danyill commented 1 year ago

This still seems to be an issue with 1.0.1:

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'createRenderRoot' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'enableUpdating' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'firstUpdated' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'getUpdateComplete' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'performUpdate' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'render' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'scheduleUpdate' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'shouldUpdate' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'update' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'updated' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {
                ~~~~~~~

node_modules/@openscd/open-scd-core/open-scd.ts:99:14 - error TS4094: Property 'willUpdate' of exported class expression may not be private or protected.

99 export class OpenSCD extends Plugging(Editing(LitElement)) {