search

openscd / open-scd-core

Apache License 2.0
5 stars 8 forks source link

Refresh of active plugin on undo/redo #93

Closed danyill closed 1 year ago

danyill commented 1 year ago

Currently in an open-scd-core plugin, as far as I can tell undo/redo buttons do not request an update on the currently in use plugin. Or -- perhaps the editCount is not being correctly modified.

The undo/redo action is happening correctly but the visual display does not appear to be updated.

I have ensured that my plugin has properties on it which should effect a change, so the plugin begins:

@property({ attribute: false })
doc!: XMLDocument;

@property() docName!: string;

@property() editCount!: number;

It looks as though editCount is undefined:

image

Even though edits have been made:

image

Happy to provide additional information.

danyill commented 1 year ago

I suspect this was resolved in d3b745a and may not be an issue with a new core release.

danyill commented 1 year ago

I can confirm that this is not an issue when working off the main branch, so I will close this issue.